vrozov commented on a change in pull request #1264: DRILL-6422: Update guava
to 23.0 and shade it
URL: https://github.com/apache/drill/pull/1264#discussion_r200172239
##########
File path:
common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java
##########
@@ -54,7 +53,7 @@
public class MapWithOrdinal<K, V> implements Map<K, V> {
private final static Logger logger =
LoggerFactory.getLogger(MapWithOrdinal.class);
- private final Map<K, Entry<Integer, V>> primary = Maps.newLinkedHashMap();
+ private final Map<K, Entry<Integer, V>> primary = new LinkedHashMap<>();
private final IntObjectHashMap<V> secondary = new IntObjectHashMap<>();
private final Map<K, V> delegate = new Map<K, V>() {
Review comment:
What is the purpose of the `delegate`? I'd recommend limiting this class
changes to updated imports only and refactor it in a separate JIRA/PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
