Ben-Zvi commented on a change in pull request #1363: DRILL-6549: batch sizing
for nested loop join
URL: https://github.com/apache/drill/pull/1363#discussion_r200802245
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestOutputBatchSize.java
##########
@@ -2287,6 +2292,341 @@ public void testHashAggMax() throws
ExecutionSetupException {
opTestBuilder.go();
}
+ @Test
+ public void testNestedLoopJoinMultipleOutputBatches() throws Exception {
+ LogicalExpression functionCallExpr = new FunctionCall("equal",
+ ImmutableList.of((LogicalExpression) new FieldReference("c1",
ExpressionPosition.UNKNOWN),
+ (LogicalExpression) new FieldReference("c2",
ExpressionPosition.UNKNOWN)),
+ ExpressionPosition.UNKNOWN);
+
+ NestedLoopJoinPOP nestedLoopJoin = new NestedLoopJoinPOP(null, null,
JoinRelType.INNER, functionCallExpr);
+ mockOpContext(nestedLoopJoin, initReservation, maxAllocation);
Review comment:
Just a comment: This test calls `mockOpContext()`, while the other new NLJ
tests don't. I tested all with and without this call, and it seems to make no
difference anyway ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
