paul-rogers commented on a change in pull request #1114: Drill-6104: Added
Logfile Reader
URL: https://github.com/apache/drill/pull/1114#discussion_r200863229
##########
File path: src/main/resources/checkstyle-config.xml
##########
@@ -30,7 +30,7 @@
<module name="UnusedImports"/>
<module name="IllegalImport">
<!-- For "org.apache.commons.lang.*" classes use the corresponding class
from "org.apache.commons.lang3.*" -->
- <property name="illegalPkgs"
value="com.google.hive12,com.beust.jcommander.internal,jersey.repackaged,org.apache.commons.lang"/>
+ <property name="illegalPkgs"
value="com.google.hive12,jersey.repackaged,org.apache.commons.lang"/>
Review comment:
Which aspect was being used? There is no comment in the config file to say
why that library was excluded. Without that info, I'd kind of assume that there
was a good reason, and find some other way to get the tests to work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
