vrozov commented on a change in pull request #1367: DRILL-6585: PartitionSender clones vectors, but shares field metdata URL: https://github.com/apache/drill/pull/1367#discussion_r201149705
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/orderedpartitioner/OrderedPartitionRecordBatch.java ########## @@ -23,6 +23,7 @@ import java.util.concurrent.LinkedBlockingQueue; import java.util.concurrent.TimeUnit; +import org.apache.calcite.rel.RelFieldCollation.Direction; Review comment: I'd prefer to avoid any formatting changes including `import` reorder unless a method, a class or a file is modified to include a fix. I don't see anything being fixed in `OrderedPartitionRecordBatch.java` except for `final` declarations. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
