arina-ielchiieva commented on a change in pull request #1370: DRILL-5797: Use
Parquet new reader more often
URL: https://github.com/apache/drill/pull/1370#discussion_r201324792
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/AbstractParquetScanBatchCreator.java
##########
@@ -161,20 +167,24 @@ private ParquetMetadata readFooter(Configuration conf,
String path) throws IOExc
}
}
- private boolean isComplex(ParquetMetadata footer) {
+ private boolean isComplex(ParquetMetadata footer, List<SchemaPath> columns) {
MessageType schema = footer.getFileMetaData().getSchema();
- for (Type type : schema.getFields()) {
- if (!type.isPrimitive()) {
- return true;
+ if (Utilities.isStarQuery(columns)) {
+ for (Type type : schema.getFields()) {
+ if (!type.isPrimitive()) {
+ return true;
+ }
}
- }
- for (ColumnDescriptor col : schema.getColumns()) {
- if (col.getMaxRepetitionLevel() > 0) {
- return true;
+ for (ColumnDescriptor col : schema.getColumns()) {
+ if (col.getMaxRepetitionLevel() > 0) {
+ return true;
+ }
}
+ return false;
+ } else {
+ return containsComplexColumn(footer, columns);
Review comment:
Basically `isComplex` and `containsComplexColumn` does the same, why would
split it into semantically the same methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
