bitblender commented on a change in pull request #1355: DRILL-6560: Enhanced
the batch statistics logging enablement
URL: https://github.com/apache/drill/pull/1355#discussion_r201167369
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -704,5 +704,8 @@ public static String bootDefaultFor(String name) {
public static final String STATS_LOGGING_FG_BATCH_SIZE_OPTION =
"drill.exec.stats.logging.fine_grained.batch_size";
public static final BooleanValidator STATS_LOGGING_BATCH_FG_SIZE_VALIDATOR =
new BooleanValidator(STATS_LOGGING_FG_BATCH_SIZE_OPTION);
+ /** Controls the list of operators for which batch sizing stats should be
enabled */
Review comment:
Can you please explain the motivation for the naming hierarchy that you have
chosen for this option ? I would suggest
"drill.exec.stats.logging.batch_size.enabled_operators"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
