sohami commented on a change in pull request #1366: [DRILL-6581] C++ Client SSL
Implementation Fixes/Improvements
URL: https://github.com/apache/drill/pull/1366#discussion_r201435888
##########
File path: contrib/native/client/src/clientlib/channel.cpp
##########
@@ -211,6 +211,21 @@ ChannelContext*
ChannelFactory::getChannelContext(channelType_t t, DrillUserProp
}
pChannelContext = new SSLChannelContext(props, tlsVersion,
verifyMode);
+
+ if (props->isPropSet(USERPROP_CUSTOM_SSLCTXOPTIONS)){
Review comment:
No need to check `isPropSet` since you are already checking for
`!sslOptions.empty()` below.
Also I have a question regarding these custom SSL Context options. Based on
documentation
[here](https://www.openssl.org/docs/man1.0.2/ssl/SSL_CTX_set_options.html) it
helps to achieve workaround for listed bugs. But that depends upon the internal
implementation of SSL if handling for those work around is available or not. If
the handling is available then it will be used since this option is set during
`m_SSLContext` creation (See
[here](https://github.com/apache/drill/pull/1366/commits/093b4cadb4653b2e51fa13e7baadef3d0d6b8c91#diff-4649cdc0895f6abaeb47ff3f6a10eec4R104)).
So it doesn't look like we need to have this separate custom option setter ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
