Agirish commented on a change in pull request #1348: DRILL-6346: Create an 
Official Drill Docker Container
URL: https://github.com/apache/drill/pull/1348#discussion_r201914594
 
 

 ##########
 File path: distribution/pom.xml
 ##########
 @@ -485,6 +485,36 @@
         </plugins>
       </build>
     </profile>
+    <profile>
+      <!-- this profile adds/overrides few features of the 'apache-release'
+        profile in the parent pom. -->
+      <id>apache-release</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>com.spotify</groupId>
+            <artifactId>dockerfile-maven-plugin</artifactId>
+            <version>1.4.3</version>
+            <executions>
+              <execution>
+                <id>docker-image</id>
+                <goals>
 
 Review comment:
   Yeah, I agree - but there is no clean way to do it. We could add some notes 
in the dev docs later perhaps? Or do you have a different suggestion?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to