jbimbert commented on a change in pull request #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#discussion_r202062739
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/RangeExprEvaluator.java ########## @@ -258,21 +258,28 @@ public long getRowCount() { final ValueHolder minFuncHolder = InterpreterEvaluator.evaluateFunction(interpreter, args1, holderExpr.getName()); final ValueHolder maxFuncHolder = InterpreterEvaluator.evaluateFunction(interpreter, args2, holderExpr.getName()); + Statistics<T> statistics; switch (destType) { - //TODO : need handle # of nulls. case INT: - return getStatistics( ((IntHolder)minFuncHolder).value, ((IntHolder)maxFuncHolder).value); + statistics = getStatistics( ((IntHolder)minFuncHolder).value, ((IntHolder)maxFuncHolder).value); Review comment: Done. Checked other occurrences. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services