ppadma commented on a change in pull request #1373: DRILL-6517: Hash-Join: If
not OK, exit early from prefetchFirstBatchFromBothSides
URL: https://github.com/apache/drill/pull/1373#discussion_r202367354
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -289,7 +283,13 @@ private IterOutcome sniffNonEmptyBatch(int inputIndex,
RecordBatch recordBatch)
if (recordBatch.getRecordCount() == 0) {
continue;
}
- // We got a non empty batch
+ // We got a non empty batch; update the memory manager
+ final boolean isBuildSide = inputIndex == 1;
+ final int side = isBuildSide ? RIGHT_INDEX : LEFT_INDEX;
+ // For the build side, use aggregate i.e. average row width across
batches
+ batchMemoryManager.update(side, 0, isBuildSide);
Review comment:
That's true. even better :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
