paul-rogers commented on issue #1244: DRILL-6373: Refactor Result Set Loader 
for Union, List support
URL: https://github.com/apache/drill/pull/1244#issuecomment-404987892
 
 
   @sohami, the cost of my proposed fix has exceeded its benefit -- we're just 
not converging. I've closed that PR and will look for another solution. Rather 
than use the `MaterializedField` to get the type, I'll ad code that does a 
switch statement on the vector type to learn the "real" type, leaving the 
`MaterializedField` to hold the pretend type for the `values` field of a 
`Nullable` vector.
   
   This should not be hard: we already have generated code that parses the 
vector type. I can use this to manufacture a `MajorType` that matches the 
vector class; bypassing the need for correct `MaterializedField` data, and thus 
eliminating the need to change the vector code.
   
   Revision to be done soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to