paul-rogers commented on a change in pull request #1383: DRILL-6613: Refactor
MaterializedField
URL: https://github.com/apache/drill/pull/1383#discussion_r203252841
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -792,7 +792,7 @@ private void setupOutputContainerSchema() {
}
// make sure to project field with children for children to show up in
the schema
- final MaterializedField projected = field.withType(outputType);
+ final MaterializedField projected = field.copy(outputType);
Review comment:
The `withType` is clearer. With `copy`, we have to infer that this is "copy
fields from the give field except for type, which we are changing." `withType`
is similar to usages of this pattern elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
