cgivre commented on issue #1114: DRILL-6104: Added Logfile Reader URL: https://github.com/apache/drill/pull/1114#issuecomment-405957791 Commits squashed and proper commit message added. Regarding the unit tests, is there an example of a unit test for when we are expecting Drill to throw an exception? > On Jul 18, 2018, at 09:30, Arina Ielchiieva <[email protected]> wrote: > > @cgivre <https://github.com/cgivre> looks like PR is ready to commit. Please squash the commits and leave one with proper commit message. Maybe add extra unit tests as Paul asked if you have time. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/drill/pull/1114#issuecomment-405931381>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFQfvv8-OJCdbadInSD8XoAFueSBUTH1ks5uHziKgaJpZM4R7EFM>. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
