parthchandra commented on a change in pull request #1333: DRILL-6410: Memory
leak in Parquet Reader during cancellation
URL: https://github.com/apache/drill/pull/1333#discussion_r203556768
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
##########
@@ -284,30 +278,9 @@ protected void nextInternal() throws IOException {
}
- private void waitForExecutionResult() throws InterruptedException,
ExecutionException {
- // Get the execution result but don't remove the Future object from the
"asyncPageRead" queue yet;
- // this will ensure that cleanup will happen properly in case of an
exception being thrown
- asyncPageRead.peek().get(); // get the result of execution
- // Alright now remove the Future object
- asyncPageRead.poll();
- }
-
@Override public void clear() {
//Cancelling all existing AsyncPageReaderTasks
- while (asyncPageRead != null && !asyncPageRead.isEmpty()) {
- try {
- Future<Void> f = asyncPageRead.poll();
- if(!f.isDone() && !f.isCancelled()){
- f.cancel(true);
- } else {
- f.get(1, TimeUnit.MILLISECONDS);
- }
- } catch (RuntimeException e) {
- // Do Nothing
- } catch (Exception e) {
- // Do nothing.
- }
- }
+ executableTasksLatch.await(() -> true);
Review comment:
Isn't the original code doing the same thing that `await` is doing? TBH, I'd
really like to understand where the memory leak was occurring. (Just trying to
understand how this PR, does, in fact, fix the issue)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
