vrozov commented on a change in pull request #1298: DRILL-5796: Filter pruning
for multi rowgroup parquet file
URL: https://github.com/apache/drill/pull/1298#discussion_r203788769
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/stat/ParquetIsPredicate.java
##########
@@ -114,8 +115,7 @@ public boolean canDrop(RangeExprEvaluator<C> evaluator) {
*/
private static LogicalExpression createIsTruePredicate(LogicalExpression
expr) {
return new ParquetIsPredicate<Boolean>(expr, (exprStat, evaluator) ->
- //if max value is not true or if there are all nulls -> canDrop
- isAllNulls(exprStat, evaluator.getRowCount()) ||
exprStat.hasNonNullValue() && !((BooleanStatistics) exprStat).getMax()
+ exprStat.hasNonNullValue() && !((BooleanStatistics) exprStat).getMax()
|| isAllNulls(exprStat, evaluator.getRowCount()) ? RowsMatch.NONE :
checkNull(exprStat)
Review comment:
Please make sure to keep the original order of expressions unless it needs
to be changed for a reason. If there is a reason to change it here or *in any
other places*, please provide an explanation. I don't see why it needs to be
changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
