vrozov commented on a change in pull request #1387: DRILL-6603: Set num_nulls
for parquet statistics to -1 when actual number is not defined.
URL: https://github.com/apache/drill/pull/1387#discussion_r203798662
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/metadata/MetadataBase.java
##########
@@ -108,6 +105,18 @@
public static abstract class ColumnMetadata {
+
+ /**
+ * Number of nulls is considered to be valid if its value is not null and
-1.
+ *
+ * @return true if nulls value is defined, false otherwise
+ */
+ @JsonIgnore
+ public boolean isNullsDefined() {
+ Long nulls = getNulls();
Review comment:
@arina-ielchiieva My major concern is not the name of the method, but using
`Long` when `long` should be used. Using `long` will also address my second
major concern: using `null` and `-1` for "not set" definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
