ilooner commented on issue #1296: DRILL-5365: Prevent plugin config from changing default fs. Make DrillFileSystem Immutable. URL: https://github.com/apache/drill/pull/1296#issuecomment-406743060 @sohami Thanks for saving the day on this PR and pointing out the issues before the changes got merged. With the flaws you pointed out, I think my proposed solution has been debunked. There was one other possible source of the issue I identified earlier, but thought was less likely. "FileSystemConfigurations defined in the HiveStoragePlugin are passed to DrillFileSystem in HiveDrillNativeParquetRowGroupScan.getFsConf(). " I will explore that possible bug, and try to replicate an error scenario in a unit test. If I find anything I will update this PR with a fix for that issue. If that is not a viable bug, I will repurpose this PR to only enforce the immutability of DrillFileSystem and include no additional changes. Thanks again!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
