sohami commented on a change in pull request #1401: DRILL-6616: Batch
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205671776
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unnest/UnnestRecordBatch.java
##########
@@ -103,16 +109,19 @@ public void update() {
final MaterializedField field =
incoming.getSchema().getColumn(typedFieldId.getFieldIds()[0]);
// Get column size of unnest column.
+
RecordBatchSizer.ColumnSize columnSize =
getRecordBatchSizer().getColumn(field.getName());
+ RecordBatchSizer.ColumnSize rowIdColumnSize = getRecordBatchSizer().new
ColumnSize(rowIdVector, null);
+
// Average rowWidth of single element in the unnest list.
// subtract the offset vector size from column data size.
final int avgRowWidthSingleUnnestEntry = RecordBatchSizer
.safeDivide(columnSize.getTotalNetSize() - (getOffsetVectorWidth() *
columnSize.getValueCount()), columnSize
.getElementCount());
// Average rowWidth of outgoing batch.
- final int avgOutgoingRowWidth = avgRowWidthSingleUnnestEntry;
+ final int avgOutgoingRowWidth = avgRowWidthSingleUnnestEntry +
rowIdColumnSize.getDataSizePerEntry();
Review comment:
If still using RecordBatchSize then `getDataSizePerEntry() --->
getStdDataSizePerEntry() . `First one will return zero since the vector is
empty to start with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
