sohami commented on a change in pull request #1404: DRILL-6639: Exception
happens while displaying operator profiles for …
URL: https://github.com/apache/drill/pull/1404#discussion_r205852168
##########
File path:
protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java
##########
@@ -131,6 +139,14 @@ public static CoreOperatorType valueOf(int number)
case 43: return HIVE_DRILL_NATIVE_PARQUET_ROW_GROUP_SCAN;
case 44: return JDBC_SCAN;
case 45: return REGEX_SUB_SCAN;
+ case 46: return MAPRDB_SUB_SCAN;
Review comment:
I think for future we should come up with a strategy to avoid missing
OperatorType from protobuf and also probably separate the contrib related
format plugins or operator to have a different range of values. This will help
different distro's to also define their own operator in that specific range
rather than having conflict with Drill's internal core operators. Having
different range is still a short term solution.
For longer term we can discuss other solutions like some form of
registration techniques for all format plugin and operator which will advertise
their own unique id (thanks to @parthchandra) for suggesting it. But we can
discuss more for future improvements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
