amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch
Processing for Lateral/Unnest
URL: https://github.com/apache/drill/pull/1401#discussion_r205915503
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/LateralJoinPOP.java
##########
@@ -38,6 +38,9 @@
@JsonProperty("excludedColumns")
private List<SchemaPath> excludedColumns;
+ @JsonProperty("implicitColumn")
+ private String implicitColumn;
Review comment:
It would be better to name it more precisely as implicitRIDColumn or
something similar here as well as other places where implicitColumn is used.
The reason is in theory there could be more than 1 implicit columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
