Ben-Zvi commented on a change in pull request #1399: DRILL-6631: Streaming agg 
causes queries with Lateral and Unnest to r…
URL: https://github.com/apache/drill/pull/1399#discussion_r205921415
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/StreamingAggTemplate.java
 ##########
 @@ -40,7 +40,7 @@
 
   // First batch after build schema phase
   private boolean first = true;
 
 Review comment:
   Suggestion - rename *first* to something more meaningful - e.g.,  
*emitNotSeenYet* .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to