weijietong commented on a change in pull request #1334: DRILL-6385: Support
JPPD feature
URL: https://github.com/apache/drill/pull/1334#discussion_r206017040
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -528,6 +590,27 @@ private void initializeBuild() {
}
+ private void initializeRuntimeFilter() {
+ if (!enableRuntimeFilter) {
+ return;
+ }
+ if (runtimeFilterReporter != null) {
+ return;
+ }
+ runtimeFilterReporter = new
RuntimeFilterReporter((ExecutorFragmentContext) context);
+ RuntimeFilterDef runtimeFilterDef = popConfig.getRuntimeFilterDef();
+ if (runtimeFilterDef != null) {
Review comment:
`enableRuntimeFilter` is a global option to decide whether a HashJoin could
generate RuntimeFilter. But it does not indicate the HashJoin must have a
RuntimeFilterDef. There's some preconditions defined at the
`RuntimeFilterManager` such as Left join is not allowed to use a BF to filter
data. So we can't use `Preconditions.checkState(runtimeFilterDef != null)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
