vrozov commented on a change in pull request #1406: DRILL-6641: Fix
columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has
RowGroupInfo without column statistics
URL: https://github.com/apache/drill/pull/1406#discussion_r206253131
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScanStatistics.java
##########
@@ -61,7 +63,9 @@ public ParquetGroupScanStatistics(ParquetGroupScanStatistics
that) {
}
public long getColumnValueCount(SchemaPath column) {
- return columnValueCounts.containsKey(column) ?
columnValueCounts.get(column) : 0;
+ return Optional.ofNullable(columnValueCounts.get(column))
Review comment:
The same as other `Optional`, otherwise LGTM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services