amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-408948442 Since most of my comments have been addressed, I am +1. Thanks @weijietong. Once you address @sohami 's comments, the next steps would be: - pls file JIRAs for items we identified during code review. - rebase on master and run unit tests - mark the JIRA ready-to-commit - we'll need a volunteer to run the regression tests on QA test cluster (I will ask for volunteer) - presumably with the default FALSE setting for the JPPD feature, tests are clean, then it can be merged to master. - continue further tests with a TRUE setting
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
