Ben-Zvi commented on a change in pull request #1408: DRILL-6453: Resolve
deadlock when reading from build and probe sides simultaneously in HashJoin
URL: https://github.com/apache/drill/pull/1408#discussion_r208401247
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
##########
@@ -248,95 +257,134 @@ protected void buildSchema() throws
SchemaChangeException {
}
}
Review comment:
It would be nicer if *buildSchema()* was calling the "standard"
*prefetchFirstBatchFromBothSides()* like the other binary operators (sans MJ).
Instead of having specialized different code, and modifying the RecordBatch
just for the hash join.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
