weijietong commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-411444653 @sohami I have changed the logic to generate SV2 in the ScanBatch. It is comparatively easy now. Initially, I worried about the performance of the `RemovingRecordBatch`'s `setupNewSchema()` while generating different output schema of `ScanBatch` by applying `RuntimeFilter` with an assumption implementation of the `RemovingRecodBatch`'s `setupNewSchema()` to generate dynamic codes.But actually `RemovingRecodBatch`'s `setupNewSchema()` does not generate dynamic codes. So the changed implementation has reduced some complexity to judge whether to output a schema with SV2 or NONE. I am not sure I fully understand your proposed strategy , maybe a implementation like adding `RemovingRecodBatch` on a node . But the whole design is to connect the `Scan` node and `HashJoin` one. That changing will make more work to do. So if you have no doubt about the current changed implementation , let's it go. Btw, others you mentioned has been addressed. Please review them, tks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
