ilooner commented on a change in pull request #1344: DRILL-6461: Added basic
data correctness tests for hash agg, and improved operator unit testing
framework.
URL: https://github.com/apache/drill/pull/1344#discussion_r208721030
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggTemplate.java
##########
@@ -1175,6 +1175,7 @@ public AggIterOutcome outputCurrentBatch() {
v.getValueVector().getMutator().setValueCount(numOutputRecords);
}
+ outContainer.setRecordCount(numOutputRecords);
Review comment:
- I created an issue for centralizing setting the record counts here. We can
probably just make VectorContainer.setRecordCount set the record count for
value vectors as well instead of just itself.
https://issues.apache.org/jira/browse/DRILL-6675
- Discussed offline, I'll make the logging changes to HashAgg as part of
https://issues.apache.org/jira/browse/DRILL-6253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
