kkhatua commented on a change in pull request #1279: DRILL-5735: Allow
search/sort in the Options webUI
URL: https://github.com/apache/drill/pull/1279#discussion_r208779542
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/WebServer.java
##########
@@ -408,5 +444,46 @@ public void close() throws Exception {
if (embeddedJetty != null) {
embeddedJetty.stop();
}
+ //Deleting temp directory
+ FileUtils.deleteDirectory(getTmpJavaScriptDir());
+ }
+
+ /* Static wrapper text for JavaScript content */
+ private static final String FILE_CONTENT_HEADER =
Review comment:
I could use a standalone template file (say, `options.describe.js.template`)
and then construct the the final file with a copy from this and inject the
options and descriptions. I think that makes it cleaner and helps keep
JavaScript code outside of the Java code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
