ilooner commented on a change in pull request #1415: DRILL-6656: Disallow extra
semicolons in import statements.
URL: https://github.com/apache/drill/pull/1415#discussion_r209085506
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
##########
@@ -713,7 +713,7 @@ public void eval() {
if (length.value > 0) {
charLen = Math.min((int)length.value, charCount); //left('abc', 5)
-> 'abc'
} else if (length.value < 0) {
- charLen = Math.max(0, charCount + (int)length.value) ; //
left('abc', -5) ==> ''
+ charLen = Math.max(0, charCount + (int)length.value); // left('abc',
-5) ==> ''
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
