paul-rogers commented on issue #1429: DRILL-6676: Add Union, List and Repeated List types to Result Set Loader URL: https://github.com/apache/drill/pull/1429#issuecomment-412715369 @ilooner, thanks much for taking a look at this PR. Agree it would be great for @ppadma to review this as she's been following allow with earlier work in this series. The code here can be overwhelming if you dive right in. The best way to start is to look at the tests: to see how the code is intended to be used. The API is intended to be simple; the large bulk of code is needed to create that simple API by hiding the highly complex stuff that must be done to keep multiple vectors in sync -- with ever increasing complexity as you move from fixed-width to nullable to variable width to arrays to maps to unions to lists. Rebased on latest master. Fixed check style issues from latest rules.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
