vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage
of Guava classes by JDK ones
URL: https://github.com/apache/drill/pull/1397#discussion_r208410748
##########
File path:
contrib/storage-mongo/src/main/java/org/apache/drill/exec/store/mongo/MongoGroupScan.java
##########
@@ -278,8 +273,8 @@ private void init() throws IOException {
}
private void handleUnshardedCollection(List<String> hosts) {
- String chunkName = Joiner.on('.').join(scanSpec.getDbName(),
scanSpec.getCollectionName());
- Set<ServerAddress> addressList = Sets.newHashSet();
+ String chunkName = String.join(".", Arrays.asList(scanSpec.getDbName(),
scanSpec.getCollectionName()));
Review comment:
Why creating of the `List` is necessary? Consider using of other overloaded
`String.join()` method or `StringJoiner`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
