sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD
feature
URL: https://github.com/apache/drill/pull/1334#discussion_r211027163
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java
##########
@@ -156,9 +156,19 @@ public DoubleValidator(String name) {
}
}
- public static class IntegerValidator extends TypeValidator {
+ public static class IntegerValidator extends LongValidator {
public IntegerValidator(String name) {
- super(name, Kind.INTEGER);
+ super(name);
+ }
+
+ @Override
+ public void validate(final OptionValue v, final OptionMetaData metaData,
final OptionSet manager) {
+ super.validate(v, metaData, manager);
+ if (v.num_val > Integer.MAX_VALUE || v.num_val < Integer.MIN_VALUE) {
+ throw UserException.validationError()
+ .message(String.format("Option %s does not have a validate integer
value", getOptionName()))
Review comment:
does not have a **valid** integer value
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
