gparai commented on a change in pull request #1425: DRILL-6647: Update Calcite
version to 1.17.0
URL: https://github.com/apache/drill/pull/1425#discussion_r212095113
##########
File path:
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java
##########
@@ -162,1713 +160,1097 @@ public void close() {
super.close();
}
- @Override
- public boolean wasNull() throws SQLException {
- throwIfClosed();
- return super.wasNull();
- }
-
- // Methods for accessing results by column index
- @Override
- public String getString( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getString( columnIndex );
- }
-
- @Override
- public boolean getBoolean( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getBoolean( columnIndex );
- }
-
- @Override
- public byte getByte( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getByte( columnIndex );
- }
-
- @Override
- public short getShort( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getShort( columnIndex );
- }
-
- @Override
- public int getInt( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getInt( columnIndex );
- }
-
- @Override
- public long getLong( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getLong( columnIndex );
- }
-
- @Override
- public float getFloat( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getFloat( columnIndex );
- }
-
- @Override
- public double getDouble( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getDouble( columnIndex );
- }
-
- @Override
- public BigDecimal getBigDecimal( int columnIndex,
- int scale ) throws SQLException {
- throwIfClosed();
- return super.getBigDecimal( columnIndex, scale );
- }
-
- @Override
- public byte[] getBytes( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getBytes( columnIndex );
- }
-
- @Override
- public Date getDate( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getDate( columnIndex );
- }
-
- @Override
- public Time getTime( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getTime( columnIndex );
- }
-
- @Override
- public Timestamp getTimestamp( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getTimestamp( columnIndex );
- }
-
- @Override
- public InputStream getAsciiStream( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getAsciiStream( columnIndex );
- }
-
- @Override
- public InputStream getUnicodeStream( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getUnicodeStream( columnIndex );
- }
-
- @Override
- public InputStream getBinaryStream( int columnIndex ) throws SQLException {
- throwIfClosed();
- return super.getBinaryStream( columnIndex );
- }
-
- // Methods for accessing results by column label
- @Override
- public String getString( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getString( columnLabel );
- }
-
- @Override
- public boolean getBoolean( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getBoolean( columnLabel );
- }
-
- @Override
- public byte getByte( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getByte( columnLabel );
- }
-
- @Override
- public short getShort( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getShort( columnLabel );
- }
-
- @Override
- public int getInt( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getInt( columnLabel );
- }
-
- @Override
- public long getLong( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getLong( columnLabel );
- }
-
- @Override
- public float getFloat( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getFloat( columnLabel );
- }
-
- @Override
- public double getDouble( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getDouble( columnLabel );
- }
-
- @Override
- public BigDecimal getBigDecimal( String columnLabel,
- int scale ) throws SQLException {
- throwIfClosed();
- return super.getBigDecimal( columnLabel, scale );
- }
-
- @Override
- public byte[] getBytes( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getBytes( columnLabel );
- }
-
- @Override
- public Date getDate( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getDate( columnLabel );
- }
-
- @Override
- public Time getTime( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getTime( columnLabel );
- }
-
- @Override
- public Timestamp getTimestamp( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getTimestamp( columnLabel );
- }
-
- @Override
- public InputStream getAsciiStream( String columnLabel ) throws SQLException {
- throwIfClosed();
- return super.getAsciiStream( columnLabel );
- }
-
- @Override
- public InputStream getUnicodeStream( String columnLabel ) throws
SQLException {
- throwIfClosed();
- return super.getUnicodeStream( columnLabel );
- }
-
- @Override
- public InputStream getBinaryStream( String columnLabel ) throws SQLException
{
- throwIfClosed();
- return super.getBinaryStream( columnLabel );
- }
-
- // Advanced features:
- @Override
- public SQLWarning getWarnings() throws SQLException {
- throwIfClosed();
- return super.getWarnings();
- }
-
- @Override
- public void clearWarnings() throws SQLException {
- throwIfClosed();
- super.clearWarnings();
- }
-
@Override
public String getCursorName() throws SQLException {
- throwIfClosed();
+ checkOpen();
try {
return super.getCursorName();
- }
- catch (UnsupportedOperationException e) {
+ } catch (UnsupportedOperationException e) {
throw new SQLFeatureNotSupportedException(e.getMessage(), e);
}
}
- // (Not delegated.)
- @Override
- public ResultSetMetaData getMetaData() throws SQLException {
- throwIfClosed();
- return super.getMetaData();
- }
-
@Override
public Object getObject( int columnIndex ) throws SQLException {
- throwIfClosed();
+ checkOpen();
- final Cursor.Accessor accessor;
+ Cursor.Accessor accessor;
Review comment:
Why remove final?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
