Ben-Zvi commented on a change in pull request #1442: DRILL-6688 Data batches
for Project operator exceed the maximum specified
URL: https://github.com/apache/drill/pull/1442#discussion_r212766463
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectMemoryManager.java
##########
@@ -301,4 +323,21 @@ public void update() {
logger.debug("BATCH_STATS, incoming: {}", getRecordBatchSizer());
updateIncomingStats();
}
+
+ public static int getMetadataWidth(ValueVector vv) {
+ int width = 0;
+ if (vv instanceof NullableVector) {
+ width +=
((NullableVector)vv).getBitsVector().getPayloadByteCount(1);
+ }
+
+ if (vv instanceof VariableWidthVector) {
+ width +=
((VariableWidthVector)vv).getOffsetVector().getPayloadByteCount(1);
+ }
+
+ if (vv instanceof BaseRepeatedValueVector) {
Review comment:
Should this class be changed to the interface "RepeatedValueVector" to cover
repeated maps and lists as well ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
