bitblender commented on a change in pull request #1442: DRILL-6688 Data batches
for Project operator exceed the maximum specified
URL: https://github.com/apache/drill/pull/1442#discussion_r212781914
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/project/ProjectMemoryManager.java
##########
@@ -267,8 +284,13 @@ public void update() {
OutputWidthExpression savedWidthExpr =
columnWidthInfo.getOutputExpression();
OutputWidthVisitorState state = new
OutputWidthVisitorState(this);
OutputWidthExpression reducedExpr = savedWidthExpr.accept(new
OutputWidthVisitor(), state);
- width = ((FixedLenExpr)reducedExpr).getWidth();
+ width = ((FixedLenExpr)reducedExpr).getDataWidth();
Preconditions.checkState(width >= 0);
+ int metadataWidth = getMetadataWidth(columnWidthInfo.outputVV);
+ Preconditions.checkState(metadataWidth >= 0);
Review comment:
Will remove.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services