bitblender commented on a change in pull request #1444: DRILL-6709: Extended
the batch stats utility to other operators
URL: https://github.com/apache/drill/pull/1444#discussion_r212788123
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/util/record/RecordBatchStats.java
##########
@@ -279,4 +324,19 @@ private static void
logBatchStatsMsg(RecordBatchStatsContext batchStatsContext,
}
}
+ private static String toString(BatchIOType ioType) {
+ Preconditions.checkNotNull(ioType, "The record batch IO type cannot be
null");
+
+ switch (ioType) {
Review comment:
'case' is generally indented one level into the 'switch'.
Also, Java allows Enums to have constructors and methods that can be used
to associate a string with an enum value. This makes modification of enum names
and attributes easier. See
https://docs.oracle.com/javase/tutorial/java/javaOO/enum.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
