kkhatua commented on a change in pull request #1437: DRILL-6702: Disable CPU
Reporting for non-HotSpot JDKs
URL: https://github.com/apache/drill/pull/1437#discussion_r213193819
##########
File path: common/src/main/java/org/apache/drill/exec/metrics/CpuGaugeSet.java
##########
@@ -32,13 +32,23 @@
*/
@SuppressWarnings("restriction")
public class CpuGaugeSet implements MetricSet {
+ private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(CpuGaugeSet.class);
- private OperatingSystemMXBean osMXBean;
- private RuntimeMXBean rtMXBean;
+ private final OperatingSystemMXBean osMXBean;
+ private final RuntimeMXBean rtMXBean;
public CpuGaugeSet() {
- this.osMXBean = (OperatingSystemMXBean)
ManagementFactory.getOperatingSystemMXBean();
this.rtMXBean = ManagementFactory.getRuntimeMXBean();
+ //DRILL-6702: Instead of worrying about compiling with IBM JDK, for now,
we shall provide no CPU metrics for non-HotSpot JVMs
+ OperatingSystemMXBean tempOSMXBean = null;
+ try {
+ tempOSMXBean = (OperatingSystemMXBean)
ManagementFactory.getOperatingSystemMXBean();
+ } catch (ClassCastException cce) {
+ logger.warn("Detected non-HotSpot JVM [{}]. CPU Metrics in the WebUI
will not be available!", System.getProperty("java.vm.name"));
+ tempOSMXBean = null;
+ }
+ this.osMXBean = tempOSMXBean;
+ System.out.println("osMXBean::" + osMXBean);
Review comment:
Agreed. The fix has been verified and I've done the clean up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
