oleg-zinovev commented on a change in pull request #1446: DRILL-6349: Drill JDBC driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM URL: https://github.com/apache/drill/pull/1446#discussion_r213392442
########## File path: common/src/main/java/org/apache/drill/common/util/DrillPlatformDependent.java ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.common.util; + +import io.netty.util.internal.PlatformDependent; + +import java.lang.reflect.Method; + +public class DrillPlatformDependent { + private final static long MAX_DIRECT_MEMORY = maxDirectMemory0(); + + public static long maxDirectMemory() { + return MAX_DIRECT_MEMORY; + } + + + private static long maxDirectMemory0() { Review comment: Looks like it can cause OOM: In Drill version of `PooledByteBufAllocatorL` exists a reflective access to `PooledByteBufAllocator.directArenas` field. It's size depends on ` DEFAULT_NUM_DIRECT_ARENA = Math.max(0, SystemPropertyUtil.getInt( "io.netty.allocator.numDirectArenas", (int) Math.min( defaultMinNumArena, PlatformDependent.maxDirectMemory() / defaultChunkSize / 2 / 3)));` Should i use a netty `PlatformDependent`, or "override" it (as `PooledByteBufAllocatorL`) ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
