Ben-Zvi commented on a change in pull request #1450: DRILL-6717: lower and
upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#discussion_r213521381
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/expr/fn/impl/TestStringFunctions.java
##########
@@ -1441,11 +1442,12 @@ public void testUpper() throws Exception {
"upper('AbC aBc') as col_space,\n" +
"upper('123ABC$!abc123.') as col_special,\n" +
"upper('') as col_empty,\n" +
- "upper(cast(null as varchar(10))) as col_null\n" +
+ "upper(cast(null as varchar(10))) as col_null,\n" +
+ "upper('привет, мир!') as col_national\n" +
Review comment:
Also added here
```+ "upper('ßßßßßßßßßß') as col_ss\n" + ```
which should yield
```"SSSSSSSSSSSSSSSSSSSS"```
as uppercase (even without Locale.GERMAN) . This was in part to check for a
buffer overflow ....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
