oleg-zinovev commented on a change in pull request #1450: DRILL-6717: lower and
upper functions not works with national characters
URL: https://github.com/apache/drill/pull/1450#discussion_r213736659
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java
##########
@@ -529,7 +538,16 @@ public void eval() {
Review comment:
I don't know reason (maybe performance or allocation of big strings ?), but
In test classes you can find simple implemenations:
org.apache.drill.udf.dynamic.LowerFunction
/ org.apache.drill.udf.dynamic.CustomUpperFunction
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
