vvysotskyi commented on a change in pull request #1453: DRILL-6710: Disallow
negative scale for decimal data type
URL: https://github.com/apache/drill/pull/1453#discussion_r214176505
##########
File path:
exec/java-exec/src/main/codegen/templates/Decimal/DecimalAggrTypeFunctions1.java
##########
@@ -92,6 +92,8 @@ public void add() {
if (outputScale.value == Integer.MIN_VALUE) {
outputScale.value = in.scale;
Review comment:
Thanks, good catch!
Check for `min(outputScale.value, MaxScale)` below is obsolete and should be
removed, since the scale of input type cannot be invalid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
