vrozov commented on a change in pull request #1446: DRILL-6349: Drill JDBC
driver fails on Java 1.9+ with NoClassDefFoundError: sun/misc/VM
URL: https://github.com/apache/drill/pull/1446#discussion_r214377427
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/FileSystemPartitionDescriptor.java
##########
@@ -180,7 +180,7 @@ protected void createPartitionSublists() {
// build a list of DFSDirPartitionLocation.
for (final List<String> dirs : dirToFileMap.keySet()) {
- locations.add( new DFSDirPartitionLocation((String [])dirs.toArray(),
dirToFileMap.get(dirs)));
+ locations.add( new DFSDirPartitionLocation(dirs.toArray(new
String[dirs.size()]), dirToFileMap.get(dirs)));
Review comment:
Why is this change necessary? As I already mentioned, I don't see why is it
necessary to go back and forth between an array and a list in this method, so I
would prefer not to introduce an unrelated change into the PR and handle it in
a separate PR/JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
