vdiravka commented on issue #1460: DRILL-6732: Queries are runnable on disable 
plugins
URL: https://github.com/apache/drill/pull/1460#issuecomment-419414069
 
 
   Hi @lushuifeng. Thanks for your first contribution and welcome!
   
   Please take a look at unit tests, a lot of them are failed, you can easily 
check the Travis build from this PR (keep in mind that some tests are excluded 
from Travis build). 
   
   I suppose the reason of that failures is System Plugins. There are two 
config types for them: `SystemTablePluginConfig` and `InfoSchemaConfig` and 
they are not deserializable. It means they are always disabled, but should be 
enabled after instantiating. If you change it, your check should pass for 
system plugins too. Please verify it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to