vdiravka commented on a change in pull request #1460: DRILL-6732: Queries are runnable on disable plugins URL: https://github.com/apache/drill/pull/1460#discussion_r216859904
########## File path: exec/java-exec/src/main/java/org/apache/calcite/jdbc/DynamicRootSchema.java ########## @@ -78,7 +78,7 @@ public void loadSchemaFactory(String schemaName, boolean caseSensitive) { try { SchemaPlus schemaPlus = this.plus(); StoragePlugin plugin = getSchemaFactories().getPlugin(schemaName); - if (plugin != null) { + if (plugin != null && plugin.getConfig().isEnabled()) { Review comment: It appears not easy to add this new exception. We should keep disabled plugins list and their schemas and then in the process of validation it is necessary to find the actual schema in this list. But since the new message is questionable, let's leave it as is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services