aravi5 commented on issue #1464: DRILL-6733: Unit tests from 
KafkaFilterPushdownTest are failing in so…
URL: https://github.com/apache/drill/pull/1464#issuecomment-420816538
 
 
   @agozhiy - Thank you for fixing this, the fix looks good.
   
   @vdiravka  - The design of `TestKafkaSuit` is very similar to design of 
`MongoTestSuit` and hence would require changes similar to the ones made in 
[storage-mongo/pom.xml](https://github.com/apache/drill/pull/923/commits/f5dfa56f33a46b92e2f9de153d82a16a77642ddf#diff-e110e2cbfd77d27e85d5121529c612bfR83).
   
   Current behavior is surefire runs tests classes twice - once as a part of 
`TestKafkaSuit` and the other by directly running classes. To prevent the 
latter from happening, changes were made in `pom.xml` for `storage-mongo` 
plugin. 
   
   These changes can be addressed as a part of a separate PR or I am happy to 
include the changes as a part of my open PR 
https://github.com/apache/drill/pull/1463.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to