vdiravka commented on a change in pull request #1455: DRILL-6724: Dump operator
context to logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#discussion_r217928942
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/BaseRootExec.java
##########
@@ -123,6 +123,21 @@ public void receivingFragmentFinished(final
FragmentHandle handle) {
logger.warn("Currently not handling FinishedFragment message");
}
+ @Override
+ public void dumpOperators() {
+ if (!operators.isEmpty()) {
+ logger.info("Operator dump started.");
+ for (CloseableRecordBatch batch : operators) {
+ batch.dump();
Review comment:
Very much info could be logged. Do we need to dump every batch before failed
batch?
Possibly the only last successfully batch is needed to dump?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
