KazydubB edited a comment on issue #1455: DRILL-6724: Dump operator context to 
logs when error occurs during query execution
URL: https://github.com/apache/drill/pull/1455#issuecomment-422468101
 
 
   @vdiravka regarding your concerns:
   
   - I suppose you are right that there is no need to dump all operators up to 
a failed one (though having this information may help recreating fragment 
operators in some cases). Dump from the failed batch might suffice in most 
cases. Maybe we should consider configuration parameter for number of batches 
to be dumped?
   
   - This `DumpCat` relies on Trace operator which should be injected to 
physical plan (see comments in [Implement Diagnostic 
Operator](https://issues.apache.org/jira/browse/DRILL-256)) and it seems that 
TraceInjector, which traverses the set of operators and injects trace operator 
before every operator is not invoked anywhere, since the trace operator does 
not support hyper vectors. Moreover this feature is poorly documented (and may 
appear unreliable as it is not being tested/accounted for since it was added 
almost 5 years ago and there are no recent jiras for the subject). And lastly, 
script to run this tool (`DumpCat`) is not shipped in Drill's distribution 
([Remove dumpcat script from Drill 
distribution](https://issues.apache.org/jira/browse/DRILL-4751)) rendering it 
hard for users to use it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to