sohami commented on a change in pull request #1470: DRILL-6746: Query can hang
when PartitionSender task thread sees a co…
URL: https://github.com/apache/drill/pull/1470#discussion_r219652726
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/SpoolingRawBatchBuffer.java
##########
@@ -119,6 +119,19 @@ public RawFragmentBatch take() throws IOException,
InterruptedException {
return buffer.take().get();
}
+ @Override
+ public RawFragmentBatch poll(long timeout, TimeUnit timeUnit) throws
InterruptedException, IOException {
+ RawFragmentBatchWrapper batchWrapper = buffer.poll(timeout, timeUnit);
+ if (batchWrapper != null) {
+ try {
+ return batchWrapper.get();
+ } catch (InterruptedException e) {
Review comment:
Thanks for catching this. Specifically for spooling buffer implementation
even `poll()` method was consuming the InterruptedException. I have made both
polls to throw `InterruptedException`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
