sohami commented on a change in pull request #1467: DRILL-5671: Set secure ACLs
(Access Control List) for Drill ZK nodes in a secure cluster
URL: https://github.com/apache/drill/pull/1467#discussion_r218587001
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java
##########
@@ -50,6 +50,8 @@ private ExecConstants() {
public static final String ZK_TIMEOUT = "drill.exec.zk.timeout";
public static final String ZK_ROOT = "drill.exec.zk.root";
public static final String ZK_REFRESH = "drill.exec.zk.refresh";
+ public static final String ZK_ACL_PROVIDER = "drill.exec.zk.acl_provider";
+ public static final String ZK_APPLY_SECURE_ACL =
"drill.exec.zk.apply_secure_acl";
Review comment:
I don't see why both the parameters are required. We can just have a
provider which can be configured to use secure, non-secure or custom ACL
provider ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
