Hello Ihor, Welcome to the Drill community!!
I would re-think the motivation for this JIRA. Calcite does not distinguish between the comma-separated and CROSS JOIN ways as you pointed out precisely because they are the same! It seems like you want to provide a mechanism to by-pass the nlj_scalar_only option for certain queries. You could easily do that by setting the option to false for those queries where you want to use the CROSS JOIN syntax instead. Could you please mention if there is another use-case that motivates your fix? Having said that, I think it would be better to go with the (unwieldy) option 2. IMHO it would be misleading to set `isCrossJoinDone` only for queries using the CROSS JOIN syntax. Gautam On Thu, Sep 27, 2018 at 2:42 PM Hanumath Rao Maduri <[email protected]> wrote: > Hello Ihor, > > I am not clear on the mentioned goal of this JIRA. Can you please clarify > on this using some examples. > "But main goal of this task is to allow explicit cross joins in queries > when option is enabled and at the same time disallow other ways to execute > cross joins (for example, list tables via comma in FROM section of query > without condition) while option is enabled. " > At-least from what I understand regarding the support of cross joins, is to > enable the cross join whenever a comma separated syntax without conditions > are also enabled. Currently cross join is not supported at all. > > It's support should be similar to that of comma separated query syntax > without conditions. > > Thanks, > -Hanu > > > > On Thu, Sep 27, 2018 at 10:14 AM Ihor Huzenko <[email protected]> > wrote: > > > Dear Drillers, > > > > I'm trying to implement support for CROSS JOIN syntax in Apache Drill. > > But after long investigation I finally run out of ideas and don't see > > proper way > > how this could be implemented without changes to Calcite. I'm new to > Drill > > and > > Calcite and I would appreciate any help. Please, take a look at my > comment > > under the issue > https://urldefense.proofpoint.com/v2/url?u=https-3A__issues.apache.org_jira_browse_DRILL-2D786&d=DwIBaQ&c=cskdkSMqhcnjZxdQVpwTXg&r=jGaWXfAULy7L7yLSDM6rFQ&m=ygqa-ysfCaLMCHkOcEeKtXbPqXjuGkeDG6x1fvN0pdE&s=n02vv6QWCZ3j05oQYcK9APfheH2UYdOffMRz_uKEKZo&e= > . > > > > Thank you in advance, Igor Guzenko > > >
